Sounds to me like the classic "your pipes are old, so you need to do something about it" tactic. The truth is: flushing is only worth it if you've got concrete problems. Cloudy water, discoloration, weird smells, or suddenly lower pressure - those are the real indicators. As long as that's not happening, regular flushing is more about making money than necessity.
With 30-year-old pipes, a flush can definitely be worth doing once to see what's going on - but not as routine maintenance every couple of years, more as a one-time measure or if those problems actually show up. A plumber who wants to push regular flushing on you without concrete symptoms should make you suspicious.
A practical tip I haven't seen mentioned yet: check your water quality yourself before you call anyone. Just run the first water from your tap in the morning into a glass bottle for a week and watch if it gets clearer or stays brown. If it's clear right away, you probably don't need to do anything. If it stays cloudy or takes a while to clear up - then you've got a real problem and flushing could help.