Your neighbor has a point, but that doesn't mean it's a bad idea for your specific situation. Elevated tanks are no longer the only solution or the most modern, but they're still practical when you have weak water pressure from the network. If the water comes in weak, a tank will give you consistent pressure at the upper-floor faucets without depending on municipal pressure being constant. What's changed is that now there are alternatives: a hydropneumatic tank (pressure tank) works better with a pump and gives you more control, or directly a constant-pressure pump that keeps the faucets steady without needing a giant tank on the roof.
The question is which one fits better with what you need. The elevated tank is still cheaper to install and doesn't require electricity to work (though a small pump to fill it helps). A hydropneumatic tank costs more but takes up way less space and is more energy-efficient. If your house has two stories and the pressure is weak, I'd go for a combo: a pump that fills a smaller tank (or directly a hydropneumatic tank) to have real pressure everywhere, instead of one of those old-style tanks that takes up half the roof.
What I'd really recommend is that you consult with someone who can see your setup. The decision depends on how much real pressure you actually have, how much water you use, and whether your roof can handle the weight. But "outdated" doesn't mean it doesn't work; it just means there are options that work better with less space.